VASL Patch

DougRim

Forum Guru
Joined
Apr 23, 2012
Messages
1,957
Reaction score
2,234
Location
Ottawa
Country
llCanada
@uckelman I have received one comment that vasl6.3.3.1 did not work with 3.6.0. It certainly does work with 3.5.8 because I tested that. I have not yet had a chance to test with 3.6.0. Here is the errorlog extract I was given:

2021-12-03 18:43:14,637 [51164-AWT-EventQueue-0] INFO VASL.build.module.map.boardArchive.BoardArchive - Unable to read the board metadata in board archive bdFAWJ1a
2021-12-03 18:43:14,639 [51164-AWT-EventQueue-0] INFO VASL.build.module.map.boardArchive.BoardArchive - Unable to read the board metadata in board archive F:\VASSAL\boards\ASL\bdFAWJ1a 2021-12-03 18:43:14,654 [51164-AWT-EventQueue-0] INFO VASSAL.tools.io.ProcessLauncher - launching F:\VASSAL\jre\bin\java -classpath lib\Vengine.jar -Xmx153M -DVASSAL.id= -Duser.home=C:\Users\JobboFett-PC -DVASSAL.port=64311 VASSAL.tools.image.tilecache.ZipFileImageTiler F:\VASSAL\boards\ASL\bdFAWJ1a C:\Users\JobboFett-PC\AppData\Roaming\VASSAL\tiles\8308171a1001af8b6840f18818de86013da0dffb 256 256 bdFAWJ1a.gif
2021-12-03 18:43:15,180 [50620-main] INFO VASSAL.tools.image.tilecache.ZipFileImageTiler - Starting
2021-12-03 18:43:15,250 [50620-main] INFO VASSAL.tools.image.tilecache.FileArchiveImageTiler - Tiling bdFAWJ1a.gif
2021-12-03 18:43:15,429 [50620-main] INFO VASSAL.tools.image.tilecache.ZipFileImageTiler - Exiting
2021-12-03 18:43:15,448 [51164-AWT-EventQueue-0] INFO VASL.build.module.map.boardArchive.BoardArchive - Unable to read the board metadata in board archive bdFAWJ1a
2021-12-03 18:43:15,458 [51164-AWT-EventQueue-0] WARN VASSAL.tools.ErrorDialog - Source: bdFAWJ1a.gif Error: Image not found. See the errorlog for more details.
2021-12-03 18:43:16,637 [51164-AWT-EventQueue-0] INFO VASL.build.module.ASLMap - VASL.build.module.map.boardPicker.BoardException: VASL LOS disabled - Board FAWJ1a does not support LOS checking. VASSAL los active
 

uckelman

Senior Member
Joined
Sep 12, 2011
Messages
714
Reaction score
439
Location
Durham
Country
llUnited Kingdom
Did they say what didn't work? I see no problems in that error log. I tried the test module I built on both Linux and Windows and it seemed fine.

It would help if they'd given you the entire error log.
 

DougRim

Forum Guru
Joined
Apr 23, 2012
Messages
1,957
Reaction score
2,234
Location
Ottawa
Country
llCanada
Did they say what didn't work? I see no problems in that error log. I tried the test module I built on both Linux and Windows and it seemed fine.

It would help if they'd given you the entire error log.
Understood.

From his Facebook comment to me: "essentially no maps load, VASL says it cannot load the .gif files, and usually specifies that it cannot find the orientation for the upper left as the value is "null" ". So, pretty much the same issues as the GS thread from earlier today:


As you know, this "lots-of-issues" thread took place before I posted the patch.
 

Roadtogundagai

Panty Sniffer
Joined
Apr 8, 2007
Messages
2,605
Reaction score
258
Location
Sheeplandia
First name
Tony
Country
llNew Zealand
This might just be me, but I found that VASL 6.6.3.1 with VASSAL 3.6.1 retains the missing maps bug. Works fine with 3.5.8 (which is an easy work around).

19752
 

uckelman

Senior Member
Joined
Sep 12, 2011
Messages
714
Reaction score
439
Location
Durham
Country
llUnited Kingdom
TL;DR: 6.6.3.1 doesn't work because it doesn't contain the patch.

I was puzzled to see that 6.6.3.1 didn't work, because the patch for which I gave you a PR is what went into the test module I built, which worked for me on Windows with Vassal 3.6. It's also the same code that went into the VSQL module Brent and I are updating, which worked for him on Windows.

I unpacked vasl-6.6.3.1.vmod and decompiled ASLBoardPicker.class, the only file modified by the patch, to verify that the code had in fact been modified---and discovered that it had not. There's no getCacheDir() method defined in that class, and the call to Info.getConfDir() that it should replace is still there.

It looks like @DougRim built 6.6.3.1 without the patch; given that, I'd expect to see the same behavior as 6.6.3, which is what we're in fact seeing. (Doug, did you forget to pull after merging the PR?)
 
Last edited:

DougRim

Forum Guru
Joined
Apr 23, 2012
Messages
1,957
Reaction score
2,234
Location
Ottawa
Country
llCanada
TL;DR: 6.6.3.1 doesn't work because it doesn't contain the patch.

I was puzzled to see that 6.6.3.1 didn't work, because the patch for which I gave you a PR is what went into the test module I built, which worked for me on Windows with Vassal 3.6. It's also the same code that's went into the VSQL module Brent and I are updating, which worked for him on Windows.

I unpacked vasl-6.6.3.1.vmod and decompiled ASLBoardPicker.class, the only file modified by the patch, to verify that the code had in fact been modified---and discovered that it had not. There's no getCacheDir() method defined in that class, and the call to Info.getConfDir() that it should replace is still there.

It looks like @DougRim built 6.6.3.1 without the patch; given that, I'd expect to see the same behavior as 6.6.3, which is what we're in fact seeing. (Doug, did you forget to pull after merging the PR?)
Clearly my error somewhere along the line. I will do it again.
 

uckelman

Senior Member
Joined
Sep 12, 2011
Messages
714
Reaction score
439
Location
Durham
Country
llUnited Kingdom
Thanks, Doug, and everyone for your patience.

I've confirmed that the new build does contain the fix and works with V3.6 in my Windows VM. Everything is sorted now.
 

Maxwelk1

Member
Joined
Apr 21, 2017
Messages
188
Reaction score
42
Location
Montross VA
First name
Lafajita
Country
llUnited States
Thanks, Doug, and everyone for your patience.

I've confirmed that the new build does contain the fix and works with V3.6 in my Windows VM. Everything is sorted now.
THANK YOU THANK YOU THANK YOU! I can now work with 6.6.3.1 with files from Rising Sun!
 
Top