VASL Auto report moves not recorded in logfile.

A_T_Great

Senior Member
Joined
Oct 15, 2011
Messages
804
Reaction score
578
Location
Maine
Country
llUnited States
Hello,
When using the keypad to move units, the auto report moves are showing up in the chat window, but they are not being recorded in the logfile. When my opponent opens the logfile only what I typed shows up in the log. The counter moves on the map, but the auto report moves isn't showing up in the chat bar. If I drag the counter on the map, the moves show up in the chat bar, and is recorded in the log. If I reopen the logfile, I can't see the auto report moves either. I can't attach logfiles here, so let me know if you need one.
 
Last edited:

ScottRomanowski

Forum Guru
Joined
Jul 31, 2010
Messages
1,616
Reaction score
2,087
Location
Massachusetts
Country
llUnited States
I'm A_T's opponent and I can reproduce the problem. I confirmed that I have "Auto-report moves" checked. I'm using VASL 6.6.2 and VASSAL 3.5.7. I created a 666, started logging, moved it using three different methods, ended the logfile (this part is in green), loaded it, and stepped through it (in blue). Here's the text:
- Logging begun
<Scott Romanowski> - I will move the 666 to M6 using the mouse
* 6-6-6 1sq moves L5 -> M6 *
<Scott Romanowski> - Moved
<Scott Romanowski> - I will move the 666 to N6 using the keyboard combination Ctrl+NumPad-3
* 6-6-6 1sq moves M6 -> N6 *
<Scott Romanowski> - Moved
<Scott Romanowski> - I will move the 666 to O7 by right-clicking on it and selecting Move->dir3 from the pop-up menu
* 6-6-6 1sq moves N6 -> O7 *
<Scott Romanowski> - Moved
<Scott Romanowski> - End of logfile

- Logfile written.
- Loading ReproduceNonLoggingBug.vlog ...

- Using board(s): 01(v6.2)
- VASL LOS Enabled
- Loaded ReproduceNonLoggingBug.vlog
<Scott Romanowski> - I will move the 666 to M6 using the mouse
* 6-6-6 1sq moves L5 -> M6 *
<Scott Romanowski> - Moved
<Scott Romanowski> - I will move the 666 to N6 using the keyboard combination Ctrl+NumPad-3
<Scott Romanowski> - Moved
<Scott Romanowski> - I will move the 666 to O7 by right-clicking on it and selecting Move->dir3 from the pop-up menu
<Scott Romanowski> - Moved
<Scott Romanowski> - End of logfile



As you can see, when I used Ctrl+NumPad-3 or used the pop-up menu, those moves were not recorded in the logfile. The counter's movements were recorded, as you can see if you step through the logfile. The map auto-centers on the counter's movement, which to me indicates that it is just a problem with the auto-report feature.
 

Attachments

ScottRomanowski

Forum Guru
Joined
Jul 31, 2010
Messages
1,616
Reaction score
2,087
Location
Massachusetts
Country
llUnited States
Check your preferences....
No issues here.
@Stewart, what versions are you using? If you duplicate the steps I did above and load the logfile, do you see the auto-reported move text when moving by keypad or menu, the second and third methods I used?

@A_T_Great the trick is to put the files in a .zip file; you can upload .zip files here.
 

DougRim

Forum Guru
Joined
Apr 23, 2012
Messages
1,957
Reaction score
2,234
Location
Ottawa
Country
llCanada
Log file issues are typically VASSAL rather than VASL.

@uckelman I recall we had a recent bug with keystroke movement - for vehicles I think. Could the fix for that have triggered this?
 

uckelman

Senior Member
Joined
Sep 12, 2011
Messages
714
Reaction score
439
Location
Durham
Country
llUnited Kingdom
Possibly. Is this reproducible in 3.5.8? 3.6.0-beta2?
 

uckelman

Senior Member
Joined
Sep 12, 2011
Messages
714
Reaction score
439
Location
Durham
Country
llUnited Kingdom
Ok. What's the last version where you can't reproduce the problem?
 

ScottRomanowski

Forum Guru
Joined
Jul 31, 2010
Messages
1,616
Reaction score
2,087
Location
Massachusetts
Country
llUnited States
I went back to VASSAL 3.2.17 and VASL 6.5.1. The bug is not present there.
- Using board(s): 01(v6.2)
* 6-6-6 1sq created in L5 *
* 6-6-6 1sq moves L5 -> E3 *
<Scott Romanowski> - Move with the mouse
* 6-6-6 1sq moves E3 -> F3 *
<Scott Romanowski> - Moved
<Scott Romanowski> - move with Ctrl+Numpad-3
* 6-6-6 1sq moves F3 -> G4 *
<Scott Romanowski> - Moved
<Scott Romanowski> - Move by pop-up menu
* 6-6-6 1sq moves G4 -> H4 *
<Scott Romanowski> - Moved

- Logfile written.
- Loading ReproduceBug3217-651.vlog ...

- Using board(s): 01(v6.2)
- Loaded ReproduceBug3217-651.vlog
<Scott Romanowski> - Move with the mouse
* 6-6-6 1sq moves E3 -> F3 *
<Scott Romanowski> - Moved
<Scott Romanowski> - move with Ctrl+Numpad-3
* 6-6-6 1sq moves F3 -> G4 *
<Scott Romanowski> - Moved
<Scott Romanowski> - Move by pop-up menu
* 6-6-6 1sq moves G4 -> H4 *

<Scott Romanowski> - Moved
 

ScottRomanowski

Forum Guru
Joined
Jul 31, 2010
Messages
1,616
Reaction score
2,087
Location
Massachusetts
Country
llUnited States
I have not tested that. I have only tested the combinations I reported on, and every combination I tested I reported.
Which VASL does 3.5.4 work with?
 
Last edited:

uckelman

Senior Member
Joined
Sep 12, 2011
Messages
714
Reaction score
439
Location
Durham
Country
llUnited Kingdom
No idea. The piece of information I need if I'm going to look into the bug is the last version of Vassal where the problem doesn't occur.
 

DougRim

Forum Guru
Joined
Apr 23, 2012
Messages
1,957
Reaction score
2,234
Location
Ottawa
Country
llCanada
I have checked VASL and we did make a change in 6.6.2 to fix a bug. I will have to go back and see what we did there.
 

ScottRomanowski

Forum Guru
Joined
Jul 31, 2010
Messages
1,616
Reaction score
2,087
Location
Massachusetts
Country
llUnited States
The bug is present with additional flaws if I use VASL 6.6.1 and VASSAL 3.5.8. The moves by keypad and menu are not reported as their made. Compare the transcript below to that of post#4 above. The "* 6-6-6 1sq move..." lines were not reported as I made the moves, in addition to missing from the logfile.
- Logging begun
<Scott Romanowski> - Move by mouse
* 6-6-6 1sq moves L3 -> M4 *
<Scott Romanowski> - moved
<Scott Romanowski> - move by ctrl+numpad
<Scott Romanowski> - moved
<Scott Romanowski> - move by menu
<Scott Romanowski> - moved

- Logfile written.
- Loading ReproduceBug3.5.8-6.6.1.vlog ...

- Using board(s): 01(v6.2)
- Loaded ReproduceBug3.5.8-6.6.1.vlog
<Scott Romanowski> - Move by mouse
* 6-6-6 1sq moves L3 -> M4 *
<Scott Romanowski> - moved
<Scott Romanowski> - move by ctrl+numpad
<Scott Romanowski> - moved
<Scott Romanowski> - move by menu

<Scott Romanowski> - moved

I see VASL 6.6.2 lists "Units moved with Numpad now report move and are marked moved." as a change. Perhaps that was only a partial fix, and didn't incorporate adding it to the logfile?

ETA: I tested VASL 6.6.0 + VASSAL 3.5.8 and the behavior is the same as above.
 
Last edited:

von Marwitz

Forum Guru
Joined
Nov 25, 2010
Messages
14,357
Reaction score
10,206
Location
Kraut Corner
Country
llUkraine
@ScottRomanowski - Thank you for your detailed support in trying to pinpoint the issue. I appreciate this support for the community.

(Not) needless to say and as always:
A triple 'Huzzah' to @DougRim and his VASL-crew and @uckelman and his VASSAL crew.
What you continuously do for us ASL-geeks is priceless.

von Marwitz
 
Reactions: MTL

DougRim

Forum Guru
Joined
Apr 23, 2012
Messages
1,957
Reaction score
2,234
Location
Ottawa
Country
llCanada
I have looked at what we did earlier this year. See this thread: http://www.gamesquad.com/forums/index.php?threads/vasl-counter-movement-with-keypad.159688/#post-2040068

This seems to have fixed the problem with respect to the live game but not the problem with reporting to the log file (which may not have been on our radar at the time).

@uckelman when using the mouse method in VASL, VASL.build.module.map.ASLPieceMover.java is called and eventually the parent class VASSAL.build.module.map.PieceMover.class.performDrop() method is called which triggers the necessary SendAndLog action. However, the other two methods use VASL.counters.ASLTranslate.java and while the VASSAL class MovementReporter is called, it does not appear that a SendAndLog action is being generated. VASSAL's Translate.class does contain a call to SendAndLog() in the run() method but I can't trap the code there in debug mode.

So, it appears that ASLTranslate.java is the issue. Is the solution as simple as adding a call to SendAndLog() to ASLTranslate.newTranslate()?
 

ScottRomanowski

Forum Guru
Joined
Jul 31, 2010
Messages
1,616
Reaction score
2,087
Location
Massachusetts
Country
llUnited States
I was about to start testing older versions so I could find when the problem first occurred, but I think @DougRim found the cause. Do you still want me to test combinations of older VASL & VASSAL versions?
 
Top