Problem - 07. Jan. 2025 - HIP US halfsquads "show" full-squad outline

von Marwitz

Forum Guru
Joined
Nov 25, 2010
Messages
15,139
Reaction score
11,762
Location
Kraut Corner
Country
llUkraine
VASSAL v3.7.15, VASL v6.6.9

30888

Picture says more than words:

If you HIP US halfsquads, in HIP-state, they show a blend of the full-squad and halfsquad outline, which makes everything seem more blurred.

von Marwitz
 

apbills

Elder Member
Joined
Jan 28, 2003
Messages
3,589
Reaction score
1,094
Location
Pewaukee, WI
Country
llUnited States
Apparently this is an issue with all HS. What is interesting to me is the lack of an issue with the American 747 hs. Something to latch onto when looking for the issue. I suspect it has to do with how these are layered and when you go invisible it just makes all layers semi-transparent which allows other layers to bleed through.
30889
 

zgrose

Elder Member
Joined
Jun 13, 2004
Messages
4,516
Reaction score
1,203
Location
Kingwood, TX
First name
Zoltan
Country
llUnited States
It's not just squads and half-squads. It's many HIP-able counters with layers and has been around for years.
30890
 

apbills

Elder Member
Joined
Jan 28, 2003
Messages
3,589
Reaction score
1,094
Location
Pewaukee, WI
Country
llUnited States
The American 747 counter doesn't have the issue since it does not have the layers (like any underscored morale counter). I suspect the current implementation of the counter functionality would become much more complex in order to resolve the issue. Not sure if the effort is worthwhile, but maybe someone is interested in looking at it more closely.
 

DougRim

Forum Guru
Joined
Apr 23, 2012
Messages
2,213
Reaction score
2,691
Location
Ottawa
Country
llCanada
As Zoltan said this has been around for a while. It is the oldest issue on our To Do list and dates from Feb 2014!!!

It has definitely been looked at but no-one has implemented a solution yet.

I think that one approach that has been discussed but not necessarily tried is to replace the layers with the Replace With Other trait, which just swaps one counter for another. This could be tested by a non-coder using the Edit Module function from the VASSAL window. It is very user friendly these days and I would be prepared to help someone get started. Anything that needs to be done can be done using that non-code interface. The best thing would be to start with a nationality that has a smaller set of squads, perhaps the French or the Italian. If we can see it working with one nationality we can apply it to the rest.

For anyone wishing to try this at home, it is important to understand that the different VASL infantry unit counters that appear in a nationality tab are really just copies of the same counter with the layers set to a different starting point. So for example, American 667-666-546-536-347-346-236-226 squads and hs in the counter palette are all copies of the 667 counter. Taking out the layers would change this but those existing copies could be re-purposed to be the new counters. Obviously, there are standalone counters and counters with fewer layers and copies.
 

geezer

Member
Joined
Sep 10, 2007
Messages
194
Reaction score
55
Location
Canada
Country
llCanada
@DougRim, I have actually implemented a solution for this and submitted it for implementation within Vassal (since it involves changes to the module editor) a while back. I’m waiting for it to get approved but they don’t seem in any kind of hurry.
 

DougRim

Forum Guru
Joined
Apr 23, 2012
Messages
2,213
Reaction score
2,691
Location
Ottawa
Country
llCanada
@DougRim, I have actually implemented a solution for this and submitted it for implementation within Vassal (since it involves changes to the module editor) a while back. I’m waiting for it to get approved but they don’t seem in any kind of hurry.
Well that is great news. When it gets implemented in VASSAL will all the ghosting just magically disappear or will we have to then edit the counters? Asking for a friend.

It still might be worth some minor experimentation with Replace With Other. That is not a trait that we use a lot in VASL and maybe we should see how it works.
 

uckelman

Senior Member
Joined
Sep 12, 2011
Messages
759
Reaction score
481
Location
Durham
Country
llUnited Kingdom
I have actually implemented a solution for this and submitted it for implementation within Vassal (since it involves changes to the module editor) a while back. I’m waiting for it to get approved but they don’t seem in any kind of hurry.
Which PR is this? I don't see it.
 

geezer

Member
Joined
Sep 10, 2007
Messages
194
Reaction score
55
Location
Canada
Country
llCanada
Which PR is this? I don't see it.
My memory is playing tricks on me. I did not create a PR.

Rather I created an issue ( #13665) to discuss a solution for this and completed most of the work but then stopped when I realized how slow and unresponsive the process is to get work incorporated into Vassal.

@DougRim, perhaps pointless to discuss at this point but my solution involved giving the option of having a trait start active without being always active. This would then allow to alternate between the squad and HS layers so only one was active at a time.
 

von Marwitz

Forum Guru
Joined
Nov 25, 2010
Messages
15,139
Reaction score
11,762
Location
Kraut Corner
Country
llUkraine
Rather I created an issue ( #13665) to discuss a solution for this and completed most of the work but then stopped when I realized how slow and unresponsive the process is to get work incorporated into Vassal.
Well, it seems that you have @uckelman 's attention. He's da man for VASSAL. Maybe you can make it happen if you team up.

von Marwitz
 

uckelman

Senior Member
Joined
Sep 12, 2011
Messages
759
Reaction score
481
Location
Durham
Country
llUnited Kingdom
Rather I created an issue ( #13665) to discuss a solution for this and completed most of the work but then stopped when I realized how slow and unresponsive the process is to get work incorporated into Vassal.
Who did you talk to about the issue and the work you did? This is the first I'm hearing about it. I can't be responsive if I don't know the issue exists or anyone is working on it.

That said, I no longer go looking for problems with V3. I don't want that to eat time I'd rather put toward V4. If you're expecting me to find V3 issues and spontaneously act on them---which I did for many years---that will never happen again. If there's something you want me to see, tell me; if there's something you want me to decide, make it as easy as possible for me to make a decision.
 

geezer

Member
Joined
Sep 10, 2007
Messages
194
Reaction score
55
Location
Canada
Country
llCanada
Who did you talk to about the issue and the work you did? This is the first I'm hearing about it. I can't be responsive if I don't know the issue exists or anyone is working on it.

That said, I no longer go looking for problems with V3. I don't want that to eat time I'd rather put toward V4. If you're expecting me to find V3 issues and spontaneously act on them---which I did for many years---that will never happen again. If there's something you want me to see, tell me; if there's something you want me to decide, make it as easy as possible for me to make a decision.
I was not aware I was supposed to contact you directly in order to discuss PRs and issues, I thought that was what Github was for. How exactly do you prefer to be contacted?

I have come up with another solution which does not require modifying any of the existing counters. I simply modifed the Hideable.java class so that when an image should be drawn as hidden it is drawn off board first, the transparency applied to that image and then drawn in the proper location. This makes it so there can be no bleeding of layers and only the top layer will appear. Below is the result:

30911

Obviously if other games need layers to bleed through then this solution won't work but it seems like this wouldn't be an issue based on the few other games that I play on vassal.
 

uckelman

Senior Member
Joined
Sep 12, 2011
Messages
759
Reaction score
481
Location
Durham
Country
llUnited Kingdom
I was not aware I was supposed to contact you directly in order to discuss PRs and issues, I thought that was what Github was for. How exactly do you prefer to be contacted?
For issues, here, or in our forum.
 
Top